Add Pandas as format type #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomwolf
reviewed
Apr 23, 2020
src/nlp/arrow_dataset.py
Outdated
| @@ -194,7 +194,7 @@ def set_format(self, type: Optional[str] = None, columns: Optional[List] = None) | |||
| logger.error("Tensorflow needs to be installed to be able to return Tensorflow tensors.") | |||
| else: | |||
| assert ( | |||
| type is None or type == "numpy" | |||
| type is None or type == "numpy" or type == 'pandas' | |||
| ), "Return type should be None or selected in ['numpy', 'torch', 'tensorflow']." | |||
thomwolf
reviewed
Apr 24, 2020
src/nlp/arrow_dataset.py
Outdated
| @@ -236,11 +236,16 @@ def convert_outputs(self, outputs): | |||
| import tensorflow | |||
|
|
|||
| command = tensorflow.constant | |||
| elif self._format_type == 'pandas': | |||
| import pandas | |||
| command = pandas.DataFrame | |||
There was a problem hiding this comment.
Is this better than using the native arrow conversion to pandas by the way?
I thought native would be faster
cf: https://arrow.apache.org/docs/python/pandas.html
and https://wesmckinney.com/blog/high-perf-arrow-to-pandas/
There was a problem hiding this comment.
It was less code to write 😆 but I didn't know about this diff of speed. I have pushed a new commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in the title ^^