-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix torch_dtype
in Kolors text encoder with transformers
v4.49
#10816
base: main
Are you sure you want to change the base?
Conversation
I think |
Yeah, I haven't found the exact change but it was working recently on 4.48.3 |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Let's maybe also update the |
Failing test is now just a temporary Hub issue. To re-summarize the changes we have
|
Marked as draft again, waiting for huggingface/transformers#36262 |
@hlky I think this can be reopened and merged. Change is safe to make. |
What does this PR do?
Tests for
Kolors
are failing. Tracked the issue totransformers
version update. The test model's config containstorch_dtype
as a string, in turndtype
is passed asstr
totorch.empty
, seemstorch_dtype
was previously converted to atorch.dtype
or ignored.Generally
torch_dtype
would be passed to Kolors' pipelinesfrom_pretrained
orChatGLMModel
if creating it separately, so this should be ok for end users.Edit: some tests still failing
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.