Touseef docker #733
Draft
Touseef docker #733
+351
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/smolagents/docker_executor.py
Outdated
Comment on lines
176
to
194
| stderr=False | ||
|
|
||
| if stderr: | ||
| raise ValueError(f"Code execution failed:\n{output}") | ||
| else: | ||
| if return_final_answer: | ||
| while "---OUTPUT_END---" not in output: | ||
| out, err = self.python_session.output # Get both streams | ||
| if out: | ||
| output += out.decode() | ||
| if err: | ||
| stderr += err.decode() | ||
|
|
||
| # Load output for final answer or specific results | ||
| with open('/tmp/smolagents/result.pkl', 'rb') as f: # Note path on host side | ||
| result = pickle.load(f) | ||
| else: | ||
| result = None | ||
| return result, execution_logs, return_final_answer |
There was a problem hiding this comment.
@aymeric-roucher There is an undefined variable execution_logs being referenced outside of any function and a chunk of code is also outside the function why is that?
There was a problem hiding this comment.
The code is still not working, I'll ping you when it is!
|
@touseefahmed96 the main change that I'm doing it to make the code persistent (so can run two different executions of code a and b, with b using variables defined in a) + return any output from final answer (via pickling it). These requirements are quite challenging! |
|
@aymeric-roucher sure sounds good. |
sysradium
reviewed
Feb 21, 2025
| Initialize the Docker-based Jupyter Kernel Gateway executor. | ||
| """ | ||
| self.logger = logger | ||
| self.host = host |
There was a problem hiding this comment.
This won't support Unix sockets?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.