Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old benchmark code #35730

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Remove old benchmark code #35730

merged 4 commits into from
Jan 21, 2025

Conversation

gante
Copy link
Member

@gante gante commented Jan 16, 2025

What does this PR do?

/src/transformers/benchmarks, not to be confused with the new /benchmarks, was deprecated in March 2022. We can also observe in git history that the corresponding files haven't been actively maintained since that date.

This PR removes the corresponding code, with the goal of not only removing outdated code and docs bloating our library, but also to prevent confusion with the new benchmarking code 🤗

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 🧹 🧹

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely outdated indeed.... would be good to update 👁️ 👁️

@gante gante merged commit 90b46e9 into huggingface:main Jan 21, 2025
25 checks passed
@gante gante deleted the old_benchmarks branch January 21, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants