[draft] Use vLLM in LogCompletionsCallback #2797
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements changes to completion-logging callback suggested in #2786.
Normally,
LogCompletionsCallback
calls a helper function called_generate_completions
. However, this uses the defaultmodel.generate
, which can be slower than vLLM. This PR:_generate_completions_vllm
with equivalent functionalityon_step_end
inLogCompletionsCallback
to choose whether to use vLLM or not based onargs.use_vllm
from the TrainerGenerationConfig
normally passed to__init__
in the callback toSamplingParams
compatible with vLLM.I have not fully written tests yet (hence the draft), or fully checked compatibility with non-
GRPOTrainer
trainers, but this yields identical logging as the originalLogCompletionsCallback
in my own training scripts. Posting PR draft here for early feedback.Fixes # (issue)
#2786
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.