Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the metrics completion_length_max and completion_length_min #2857

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dignfei
Copy link

@dignfei dignfei commented Feb 14, 2025

…h are very useful for monitoring the training process.

What does this PR do?

Add the metrics completion_length_max and completion_length_min, which are very useful for monitoring the training process.

Before submitting

  • [× ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • [ √] Did you read the contributor guideline,
    Pull Request section?
  • [× ] Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • [ √] Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • [√ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec
Copy link
Member

wdyt of having an histogram instead? Example: wandb.Histogram(torch.randn(20).tolist()) but with the completion lengths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants