Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRPO] Log completions at every step #2893

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lidiya-co
Copy link

What does this PR do?

Enable viewing completions at every step in wandb rather than overriding them with latest step only:

before (note my num_generations=7):
Screenshot 2025-02-18 at 9 42 33 AM

after:
Screenshot 2025-02-18 at 9 41 34 AM

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a GitHub issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@qgallouedec
Copy link
Member

Actually, I think you can access all the steps via a different wandb workspace config

@qgallouedec
Copy link
Member

Screenshot 2025-02-18 at 16 16 12

@lidiya-co
Copy link
Author

@qgallouedec Oh great, is the wandb workspace config somewhere in the docs already or should I add that instead?

@qgallouedec
Copy link
Member

TBH I really don't know how to configure the wandb workspace to get this visualization. My wandb workspace doesn't show this visualization, so I switch to one of my colleagues' workspaces. If you find the solution, please share it, I'm interested.

@semitable
Copy link

semitable commented Feb 19, 2025

If you change runs.summary["completions"] to runs.history.concat["completions"] (directly on the wandb website shown in your screenshot that is, and click the small "run" button that appears), you can already see the past completions.

Nothing is overwritten in wandb, so there's no need to resend all the information at each timestep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants