add onSuccess arg for api

huozhi · Feb 16, 2025 · b6a46a5 · b6a46a5
1 parent f5b3cfc
commit b6a46a5
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 15 deletions.
diff --git a/src/bin/index.ts b/src/bin/index.ts
@@ -12,7 +12,6 @@ import { prepare } from '../prepare'
 import { RollupWatcher } from 'rollup'
 import { logOutputState } from '../plugins/output-state-plugin'
 import { normalizeError } from '../lib/normalize-error'
-import { spawn } from 'child_process'
 
 const helpMessage = `
 Usage: bunchee [options]
@@ -251,6 +250,7 @@ async function run(args: CliArgs) {
     env: env?.split(',') || [],
     clean,
     tsconfig,
+    onSuccess,
   }
 
   const cliEntry = source ? path.resolve(cwd, source) : ''
@@ -367,19 +367,6 @@ async function run(args: CliArgs) {
   } else {
     spinner.stop(`bunchee ${version} build completed`)
   }
-
-  if (onSuccess) {
-    const successProg = spawn(onSuccess, {
-      shell: true,
-      stdio: 'inherit',
-      cwd,
-    })
-    successProg.on('exit', (code) => {
-      if (code) {
-        process.exitCode = code
-      }
-    })
-  }
 }
 
 async function main() {

diff --git a/src/bundle.ts b/src/bundle.ts
@@ -23,6 +23,7 @@ import {
 } from './typescript'
 import { collectEntriesFromParsedExports } from './entries'
 import { createAssetRollupJobs } from './rollup-job'
+import { spawn } from 'child_process'
 
 function assignDefault(
   options: BundleConfig,
@@ -46,7 +47,7 @@ function hasMultiEntryExport(exportPaths: object): boolean {
 
 async function bundle(
   cliEntryPath: string,
-  { cwd: _cwd, ...options }: BundleConfig = {},
+  { cwd: _cwd, onSuccess, ...options }: BundleConfig = {},
 ): Promise<void> {
   const cwd = resolve(process.cwd(), _cwd || '')
   assignDefault(options, 'format', 'esm')
@@ -181,6 +182,24 @@ async function bundle(
     )
 
     options._callbacks?.onBuildEnd?.(assetJobs)
+
+    // Finished building successfully
+    if (onSuccess) {
+      if (typeof onSuccess === 'string') {
+        const successProg = spawn(onSuccess, {
+          shell: true,
+          stdio: 'inherit',
+          cwd,
+        })
+        successProg.on('exit', (code) => {
+          if (code) {
+            process.exitCode = code
+          }
+        })
+      } else {
+        await onSuccess()
+      }
+    }
   } catch (error) {
     options._callbacks?.onBuildError?.(error)
     return Promise.reject(error)

diff --git a/src/types.ts b/src/types.ts
@@ -44,6 +44,7 @@ type BundleConfig = {
   pkg?: PackageMetadata
   clean?: boolean
   tsconfig?: string
+  onSuccess?: string | (() => void | Promise<void>)
 
   // hooks
   /*