Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor getExportPaths #243

Closed
huozhi opened this issue Aug 17, 2023 · 6 comments · Fixed by #244
Closed

Refactor getExportPaths #243

huozhi opened this issue Aug 17, 2023 · 6 comments · Fixed by #244
Labels
area:enhance improvement or enhancement

Comments

@huozhi
Copy link
Owner

huozhi commented Aug 17, 2023

x-ref: #228 (review)

One design improvement could be: keep getExportPaths simple, that reciving a resolved exports map instead of cwd and doing cwd operation

@devjiwonchoi
Copy link
Contributor

Do you mind if I set this as experimental, add console warn something like:

Warning: wildcard export "./*" is experimental and may change or be removed at any time.
To submit an issue, please visit https://github.com/huozhi/bunchee/issues.

It is because this feature is not yet stable and need to be more tested, and I'm thinking of wildcard support like ./...folder/*also.

@huozhi
Copy link
Owner Author

huozhi commented Aug 19, 2023

@devjiwonchoi sounds good! 👍 Let's add an experimental warning for this, thanks

@devjiwonchoi
Copy link
Contributor

devjiwonchoi commented Aug 19, 2023

Do you prefer to use syntax highlights like chalk or none?

@huozhi
Copy link
Owner Author

huozhi commented Aug 22, 2023

I'd like to keep it simple for now, just using console.log

@devjiwonchoi
Copy link
Contributor

In #244 I used console.warn and added test. If you want log, I can edit it:)

@huozhi
Copy link
Owner Author

huozhi commented Aug 26, 2023

console.warn is also fine as we stick to native logging without extra ascii colors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:enhance improvement or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants