Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add wildcard exports #228

Merged
merged 19 commits into from
Aug 4, 2023
Merged

feat: add wildcard exports #228

merged 19 commits into from
Aug 4, 2023

Conversation

devjiwonchoi
Copy link
Sponsor Contributor

@devjiwonchoi devjiwonchoi commented Jul 10, 2023 •
edited
Loading

Fixes: #199

If exports[wildcard], read exportLike files & dirs based on cwd, then replace wildcard with exportLikes.

@huozhi
Copy link
Owner

huozhi commented Jul 11, 2023

Need to reoslve the conflicts here, would be great to have more description explaining how it works with the PR

@devjiwonchoi
Copy link
Sponsor Contributor Author

Acknowledged!

@devjiwonchoi
Copy link
Sponsor Contributor Author

@huozhi typing.test.ts seems like it needs to be fixed right?

@devjiwonchoi devjiwonchoi marked this pull request as draft July 14, 2023 03:16
@huozhi
Copy link
Owner

huozhi commented Jul 15, 2023

Thanks for the PR! It's a quite big change, it I'll try to find some time to review! 🙏

@devjiwonchoi
Copy link
Sponsor Contributor Author

I've turned this to a draft since I'm working on making my codes more clear. Would be great if you take a look after I mark this as ready. Thank you!

devjiwonchoi
devjiwonchoi commented Jul 16, 2023
View reviewed changes
src/exports.ts Outdated Show resolved Hide resolved
@devjiwonchoi devjiwonchoi marked this pull request as ready for review July 16, 2023 19:08
@devjiwonchoi
Copy link
Sponsor Contributor Author

Thanks for the PR! It's a quite big change, it I'll try to find some time to review! 🙏

@huozhi Let me know if there are any predefined functions that I've missed using. Thank you!

huozhi
huozhi reviewed Jul 17, 2023
View reviewed changes
src/exports.ts Outdated Show resolved Hide resolved
@devjiwonchoi devjiwonchoi requested a review from huozhi July 31, 2023 07:27
huozhi
huozhi approved these changes Aug 4, 2023
View reviewed changes
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit:

One design improvement could be: keep getExportPaths simple, that reciving a resolved exports map instead of cwd and doing cwd operation

@huozhi huozhi merged commit da9df8f into huozhi:main Aug 4, 2023
3 checks passed
@devjiwonchoi
Copy link
Sponsor Contributor Author

I'll work on it for improvement, thank you.

@devjiwonchoi devjiwonchoi deleted the feat/wildcard-exports branch August 5, 2023 17:41
@huozhi huozhi mentioned this pull request Aug 17, 2023
Closed
@huozhi
Copy link
Owner

huozhi commented Aug 17, 2023

created an issue for it

@devjiwonchoi
Copy link
Sponsor Contributor Author

Yes I’m on it since last night. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huozhi huozhi huozhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for wildcard exports
2 participants
@devjiwonchoi @huozhi