Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic support to generate separate type declarations files when building ts dual packages #219

Merged
merged 7 commits into from
Jul 9, 2023

Conversation

promer94
Copy link
Contributor

@promer94 promer94 commented Jun 26, 2023

This PR is not perfect, but for adding just a few lines, it should produce valid TypeScript declarations for swr and other small ts project.

Closes #177

@promer94 promer94 changed the title feat: add basic support generate separate type declarations files building a ts dual packages feat: add basic support to generate separate type declarations files building a ts dual packages Jun 26, 2023
@promer94 promer94 changed the title feat: add basic support to generate separate type declarations files building a ts dual packages feat: add basic support to generate separate type declarations files when building ts dual packages Jun 26, 2023
src/build-config.ts Outdated Show resolved Hide resolved
test/integration.test.ts Outdated Show resolved Hide resolved
test/integration/ts-dual-esm-cjs/package.json Outdated Show resolved Hide resolved
test/integration/ts-dual-esm-cjs-type-module/src/index.ts Outdated Show resolved Hide resolved
src/exports.ts Outdated Show resolved Hide resolved
src/logging.ts Outdated Show resolved Hide resolved
Copy link
Owner

@huozhi huozhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks!

@huozhi huozhi merged commit f2929b0 into huozhi:main Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output types align the output file name
2 participants