Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix shared chunk extension along with parent chunk #570

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Fix shared chunk extension along with parent chunk #570

merged 4 commits into from
Aug 11, 2024

Conversation

huozhi
Copy link
Owner

@huozhi huozhi commented Aug 11, 2024

When output shared chunk file:

  • if it's ESM package and CJS chunk, use .cjs extension
  • if it's CJS package and ESM chunk, use .mjs extension
  • otherwise just use '.js' extension

Fixes #557

@huozhi huozhi merged commit 4fa92de into main Aug 11, 2024
5 checks passed
@huozhi huozhi deleted the fix/shared-js-chunk-extension branch August 11, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shared modules should inherit file extension (e.g. .mjs)
1 participant
@huozhi