feat(dts): support bundle dts #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huozhi
reviewed
Aug 20, 2024
| @@ -90,6 +91,7 @@ function parseCliArgs(argv: string[]) { | |||
| sourcemap: !!args['--sourcemap'], | |||
| cwd: args['--cwd'], | |||
| dts: args['--no-dts'] ? false : undefined, | |||
| dtsBundle: args['--dts-bundle'], | |||
There was a problem hiding this comment.
Instead of introducing a new option, we can use --no-external to achieve it.
If we bundle all the dependencies, then we bundle all the types to align as well.
There was a problem hiding this comment.
Per rollup-plugin-dts, enabling bundle dts is not recommended. So IMHO we should split this into a separate option.
There was a problem hiding this comment.
yea but I still believe users want to have types as bundled instead of relying on separate package when they specify --no-external.
I want to support types bundling for that case too. if types not working they can have a way to opt-out types bundling. I'll leave these items for later. Current approach looks good! Thanks
huozhi
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #560
Added a CLI flag
--dts-bundlethat will enablerollup-plugin-dts'srespectExternaloption.