EIP-7756 Trace updates #8006
EIP-7756 Trace updates #8006
Conversation
| new StandardJsonTracer(out, showMemory, true, true, false), | ||
| // FIXME // REVIEWME do we want to change the JSON | ||
| // debug calls to use EIP-7756 values for gas and opcode? | ||
| new StandardJsonTracer(out, showMemory, true, true, false, true), |
There was a problem hiding this comment.
Do we want to extend this to JSON-RPC calls? Currently this only impacts CLI tools (and those have a CLI override flag).
There was a problem hiding this comment.
I think having current behaviour with EIP-3155 is what makes most sense for RPC given that EIP-7756 is backwards incompatible with the current format. We have seen users complain about non conformity with other clients so any slight deviation is a problem. For instance EIP-7756 makes gasCost a number instead of an Hex string and makes op a Hex number which was previously a number.
It's best to go with no changes to RPC right now and we can just remove that flag once EOF goes in.
shemnon
force-pushed
the
eip-7756/gas-as-numbers
branch
from
1470a95 to
338e491
Compare
|
This pr is stale because it has been open for 30 days with no activity. |
shemnon
force-pushed
the
eip-7756/gas-as-numbers
branch
from
4a767bc to
d656bdd
Compare
Update tracing for EIP-7756 changes, mostly swapping hex format and numbers for opcode and gas members. Signed-off-by: Danno Ferrin <[email protected]>
EIP-3155 and EIP-7756 call for "stateRoot" where we use "postHash". Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
Signed-off-by: Danno Ferrin <[email protected]>
shemnon
force-pushed
the
eip-7756/gas-as-numbers
branch
from
d656bdd to
21d844a
Compare
|
This pr is stale because it has been open for 30 days with no activity. |
| @@ -199,6 +199,13 @@ void setBytes(final String optionValue) { | |||
| scope = INHERIT) | |||
| final Boolean showJsonAlloc = false; | |||
|
|
|||
| @Option( | |||
| names = {"--eip-3155", "--trace.eip-3155"}, | |||
There was a problem hiding this comment.
I'm not even sure if it's not worth having the default unchanged and adding a flag to display EIP-7756 style. That feels more natural to me since this PR is going into main.
EDIT: this EIP is actually backwards incompatible so another reason to leave the defaults as is.
| if (eip3155strict) { | ||
| sb.append("\"op\":").append(opcode).append(","); | ||
| } else { | ||
| sb.append("\"op\":\"").append(fastHexByte(opcode)).append("\","); |
There was a problem hiding this comment.
Correct me if I'm wrong but fastHexByte is the same as "0x" + Integer.toHexString(opcode) why not use JDK features?
PR description
Update tracing for EIP-7756 changes, mostly swapping hex format and numbers for opcode and gas members.
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests