[draft] Rework metrics to use metrics crate #361
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludfjig
force-pushed
the
simplify_metrics
branch
from
937173f to
484678c
Compare
ludfjig
changed the title
ludfjig
force-pushed
the
simplify_metrics
branch
from
484678c to
6e131b8
Compare
ludfjig
added
kind/enhancement
Signed-off-by: Ludvig Liljenberg <[email protected]>
ludfjig
force-pushed
the
simplify_metrics
branch
from
6e131b8 to
2d829d6
Compare
ludfjig
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies metrics a lot by using the
metricscrate. Themetricscrate functions similar to thelogcrate in that libraries just callcounter!,gauge!orhistogram!to record metrics, and the user of the library can decide where to send the metrics by installing an appropriate recorder/exporter.TODO: track error by code&message like before. Track function calls by name and count. Rename static strings. Consider whether to always emit metrics