support for Values keyword #1000
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naronchen
commented
Feb 17, 2025
| selectExp = std::make_unique<SelectStatementExp>(std::move(singleSelect), SelectStatementExp::CompoundOperator::Union, true /*isAll*/, std::move(prevSelectExp)); | ||
| prevSelectExp = std::move(selectExp); | ||
| // BeAssert(false && "All rows in VALUES clause must have the same number of elements"); | ||
| Issues().Report(IssueSeverity::Error, IssueCategory::BusinessProperties, IssueType::ECSQL, ECDbIssueId::ECDb_0492, "All rows in VALUES clause must have the same number of elements"); |
There was a problem hiding this comment.
In this case, I think it should be issues() instead of BeAssert()?
naronchen
commented
Feb 17, 2025
| @@ -3437,7 +3438,7 @@ BentleyStatus ECSqlParser::ParseValueExp(std::unique_ptr<ValueExp>& valueExp, OS | |||
| case OSQLParseNode::value_creation_fct: | |||
| return ParseValueCreationFuncExp(valueExp, parseNode); | |||
| default: | |||
| Issues().ReportV(IssueSeverity::Error, IssueCategory::BusinessProperties, IssueType::ECSQL, ECDbIssueId::ECDb_0493, | |||
| Issues().ReportV(IssueSeverity::Error, IssueCategory::BusinessProperties, IssueType::ECSQL, ECDbIssueId::ECDb_0737, // @todo - naron: what issue id should be here | |||
There was a problem hiding this comment.
where can I find what each issueId means?
naronchen
commented
Feb 17, 2025
| @@ -388,6 +388,17 @@ ECSqlStatus ECSqlPropertyNameExpPreparer::PrepareInSubqueryRef(NativeSqlBuilder: | |||
| ECSqlFieldFactory::CreateField(ctx, exp.GetParent()->GetAsCP<DerivedPropertyExp>(), ctx.GetCurrentScope().GetNativeSqlSelectClauseColumnCount()); | |||
| break; | |||
| } | |||
| case Exp::Type::SqlColumnName: | |||
| { | |||
| NativeSqlBuilder sqlSnippet; | |||
There was a problem hiding this comment.
i can also just append the resolved path here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#897