Expose snackbar timer in order to allow customization #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to add a progress bar which indicates the timers progress (in your customized version of the snackbar). In order to achieve that, we've moved all the timer related stuff into a separate hook, which will be exposed, and we've added a config option called
disableAutoHideTimer, which disables the internal timer (which enables us to use it then in the customized component). A nice side effect is, that the Snackbar component is freed of all the timer logic.If you have any questions or considerations please reach out.
I feel like this could deserve an example or docs, but i don't know how to add it.
This is how it can be used in the customized snackbar: