Only send message if its not null or not empty #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is raised to address the empty messages being sent in zipcall . How to check the problem:- 1) Initiate a zipcall session 2) open chat 3) continuously press enter, you will be able to see multiple empty messages which is sent in the UI
Chaphasilor
requested changes
Oct 5, 2020
public/js/chat.js
Outdated
| addMessageToScreen(msg, true); | ||
|
|
||
| } | ||
| // Add message to screen |
There was a problem hiding this comment.
That comment belongs on a different line ;)
Chaphasilor
requested changes
Oct 5, 2020
There was a problem hiding this comment.
Take a look at how it was before:
decentralized-video-chat/public/js/chat.js
Lines 769 to 770 in 4b92b8a
(the comment is above the function call)
proper positioning of doc
|
pinging @ianramzy for permissions to merge this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is raised to address the empty messages being sent in zipcall .
How to check the problem:-