-
Notifications
You must be signed in to change notification settings - Fork 27
Add OpenJ9PropsExt properties for serviceability_jvmti_j9 #34
Conversation
vm.cds is set to false for serviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java which is specific to hotspot sharedclass; vm.flagless is set to true for serviceability/jvmti/RedefineClasses/RedefineLeak.java which OpenJ9 passes; vm.opt.final.ClassUnloading is set to false for serviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java which looks for a hotspot specific "Class unloading: has_previous_versions = false". Signed-off-by: Jason Feng <[email protected]>
jenkins test sanity.functional,extended.functional amac jdk19 |
Do the three JVMTI tests in eclipse-openj9/openj9#16074 pass with this PR? |
jenkins test extended.openjdk amac jdk19 |
|
re #34 (comment): fyi |
Impact on the tests in eclipse-openj9/openj9#16074 from local testingThe above test won't run since OpenJ9 does not support
The above test won't run either since it requires The above test runs and passes with OpenJ9. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Changes work as expected.
vm.cds
is set tofalse
forserviceability/jvmti/CanGenerateAllClassHook/CanGenerateAllClassHook.java
which is specific to hotspot sharedclass;vm.flagless
is set totrue
forserviceability/jvmti/RedefineClasses/RedefineLeak.java
which OpenJ9 passes;vm.opt.final.ClassUnloading
is set tofalse
forserviceability/jvmti/RedefineClasses/RedefinePreviousVersions.java
which looks for a hotspot specificClass unloading: has_previous_versions = false
.Related to eclipse-openj9/openj9#16074
FYI @tajila
Signed-off-by: Jason Feng [email protected]