-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1575 add pv model #1766
Open
LauraMaier
wants to merge
182
commits into
master
Choose a base branch
from
issue1575_addPVModel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18,115
−8
Open
Issue1575 add pv model #1766
Changes from 1 commit
Commits
Show all changes
182 commits
Select commit
Hold shift + click to select a range
929f0b7
Add initial version of PV model structure #1575
LauraMaier 908c77d
Adapt package order to include electrical package #1575
LauraMaier d15e557
Add validation and examples package #1575
LauraMaier 25c9682
Move PV Model in base classe package #1575
LauraMaier c8df97d
Restructure base classes #1575
LauraMaier b695d77
Add first version of icons #1575
LauraMaier e81d420
Merge branch 'master' into issue1575_addPVModel
LauraMaier dcc6f21
Rename PV System model and add package #1575 [skip-ci]
LauraMaier 22c222d
Add initial PVSystem model with single diode #1575
LauraMaier a79a5bf
Adapt parameterization #1575
LauraMaier fe90fad
Merge branch 'master' into issue1575_addPVModel
LauraMaier 49685fc
Change electrical icon #1575
LauraMaier 6bd456f
Add interfaces for optical PV model #1575
LauraMaier ae3bc18
Add horizontal to tilt angle optical PV model with fixed tilt and azi…
LauraMaier 5014b4d
Rafactor parameters and variables to match conventions #1575
LauraMaier 3125854
Add simlpified Lambert W function #1575
LauraMaier 4ae5396
Add 5 p modeling approach as electrical model #1575
LauraMaier fa62ded
Add 5p modeling approach electrical PV submodel #1575
LauraMaier 37a30e0
Fix typo in reflectance #1575
LauraMaier 58b5f7c
Add first PV example model for single diode model #1575
LauraMaier 12993e5
First version of a 2 diode electrical PV model added (with / without …
nytschgeusen df1b413
Implement existing structure of electrical package of Buildings libra…
LauraMaier 401cdd4
Merge branch 'master' into issue1575_addPVModel
LauraMaier 0a0f4f6
Correct wrong within clauses with Buildings instead of IBPSA #1575
LauraMaier 820eae1
Replace wrong Modelica path to quasistationary electrical model #1575
LauraMaier 2579cdb
Adapt package structure to new structure #1575
LauraMaier 833bef1
Update package structure and add new PV package icon #1575
LauraMaier d60b2ee
Refactor base data definition #1575
LauraMaier 816b1b7
Add Base Data record for Single Diode Model and and exemplary data #1575
LauraMaier 155055d
Add general record for PV models #1575
LauraMaier 517e3a7
Some restructuring and addition of validation model #1575
LauraMaier d9f8406
Add electrical models from buildings library to repo #1575
LauraMaier af041f6
Add simulate and plot scripts and ref results from buildings for all …
LauraMaier 9ea6990
Add further existing electrical models from Buildings #1575
LauraMaier f521594
Add further mdels #1575
LauraMaier 925b06f
Add existing reference results #1575
LauraMaier df2ba25
Adapt paths in existing simulate and plots scripts #1575
LauraMaier 6254c7e
Add ,missing reference results #1575
LauraMaier bce4b43
Add new simulate and plot script #1575
LauraMaier 15d0a81
Delete unintentionally pushed simulate and plot scripts #1575
LauraMaier 90ebc30
Replace wrong paths in existing simulate and plot scripts #1575
LauraMaier 90f072c
Add further simulate and plot scripts #1575
LauraMaier 9166efe
Change wrong simulate and plot scripts to make them the same as in Bu…
LauraMaier d4adcca
Add validation NIST data for PV model #1575
LauraMaier 5fbce5b
change paths to absolute paths #1575
LauraMaier f111381
Adapt file path to relative path in resources for NIST data #1575
LauraMaier 29776b3
Rename PVSystem to PVGenerators and add simulate and plot script #1575
LauraMaier 02ab6fa
Merge branch 'master' into issue1575_addPVModel
LauraMaier d258c34
Update PV Example due to external calculation of tilted global radiat…
LauraMaier f219b0b
Refactor and fix some documentation #1575
LauraMaier 325930a
Restructure so that package.mo is not in one file #1575
LauraMaier e214b81
Merge branch 'master' into issue1575_addPVModel
LauraMaier 1f181ed
Add image resources and delete empty BaseClass package #1575
LauraMaier c89b177
Adapt missing AC models in Conversion package #1575
LauraMaier 3672232
Adapt wrong Buildings related paths in revision section and unused mo…
LauraMaier 70ca0d4
Adapted documentation of single diode model #1575
LauraMaier e2be53f
Add ThreePhasesUnbalanced, docu, and rearrange packages #1575
LauraMaier 6a3f9fa
Adapt simulate and plot scripts #1575
LauraMaier 625897e
Add ref results for ThreePhasesUnbalanced #1575
LauraMaier 8dd66f7
Add simulate and plot scripts #1575
LauraMaier 5ab8483
Add wind turbines models, ref results, simulate and plot scripts #1575
LauraMaier f7684ab
Readjust connections, rename partials, and add final units to some ou…
LauraMaier cabd001
model IBPSA.Electrical.DC.Sources.PVTwoDiodes added
nytschgeusen e566b29
Adapt documentation and parameter types #1575
LauraMaier ce39e2d
Merge branch 'master' into issue1575_addPVModel
LauraMaier 7d75bcd
Adapt html code of single-diode model #1575
LauraMaier 5b4c1ec
Replace embedded pictures by html code in documentation #1575
LauraMaier 2653df6
Restructure PV model so that irradiation models are external #1575
LauraMaier e384da3
Delete empty package in Base Classes #1575
LauraMaier 7e6b7a4
model IBPSA.Electrical.DC.Sources.PVTwoDiodes updated
nytschgeusen d975428
Further improvement of system model IBPSA.Electrical.DC.Sources.Valid…
nytschgeusen 48dfd2d
First validation data set for Rooftop PV system added
nytschgeusen 12f4d42
Merge branch 'master' into issue1575_addPVModel
LauraMaier 86a5d03
Adapt validation data #1575
LauraMaier 4b55574
adding new validation data & renaming old
BreadKM 1b0c478
adapting Modelica model
BreadKM a1bb920
Adapt mos scripts and add partial validation model #1575
LauraMaier eb5cb40
Update simulation interval in PV validation models #1575
LauraMaier 2abe874
Spring cleaning #1575
LauraMaier e2b89b1
Delete ageing since no validation for this available #1575
LauraMaier fa7d94f
reformating of example IBPSA.Electrical.DC.Sources.Validation.PVTwoDi…
nytschgeusen d0687de
model IBPSA.Electrical.DC.Sources.Validation.PVTwoDiodesRooftopBuildi…
nytschgeusen 2371c0c
Add new validation models #1575
LauraMaier 693b14c
Adapt validation use case #1575
LauraMaier 58adc96
Merge branch 'issue1764_add_electrical_package' into issue1575_addPVM…
LauraMaier 33070d7
Adapt html code #1575
LauraMaier 04d3a92
Adapt html code #1575
LauraMaier 1b2abcf
Correct html code #1575
LauraMaier 14d24a1
Correct html code #1575
LauraMaier bf05c1f
Delete unused model ref results #1575
LauraMaier 2e03f1a
Merge branch 'master' into issue1575_addPVModel
LauraMaier a5fe519
Adapt parameters and validation data #1575
LauraMaier 20d8593
Restructure PV-related packages and models #1575
LauraMaier ea42694
Adapt package order #1575
LauraMaier df01560
Adapt package order PV #1575
LauraMaier b3221c9
Delete Twodiodes model; breakpoint #1575
LauraMaier f0ea882
Add new irradiation data #1575
LauraMaier b29b8c5
Merge branch 'master' into issue1575_addPVModel
LauraMaier 6e263f8
Add NIST validation and final paper status #1575
LauraMaier 9154944
Delete two-diodes model and update package structure and reorganize g…
LauraMaier be88ebc
Delete unnecessary files and update syntax #1575
LauraMaier c533d55
Add tolerance in experimental setting #1575
LauraMaier c582a5c
Update package order #1575
LauraMaier e85d6a0
Update package order #1575
LauraMaier 69ef531
adapt package order #1575
LauraMaier d823e3b
Adapt package structure in Base Classes #1575
LauraMaier d532921
Adapt html code #1575
LauraMaier ac70d26
Add and update documentation #1575
LauraMaier d9bc6a6
Delete line colors in text annotation #1575
LauraMaier f64c567
Correct BOM errors #1575
LauraMaier 7b635c2
Update documentation #1575
LauraMaier 32da78f
Update doc #1575
LauraMaier 031dddd
Adapt documentation #1575
LauraMaier 9829c25
Change encoding #1575
LauraMaier 42a459e
Adapt comments #1575
LauraMaier 56a5bf7
Correct comments #1575
LauraMaier 3dc48eb
Correct comments #1575
LauraMaier 9efb33e
Adapt comments #1575
LauraMaier 3b6fe36
Adapt comments #1575
LauraMaier 5004c3f
Correct comments #1575
LauraMaier ae10ce0
Adapt comments #1575
LauraMaier c17683c
Adapt comments #1575
LauraMaier 41fb9b3
Adapt comments #1575
LauraMaier 85b46a4
test BOM hook
LauraMaier 8ab493f
Change BOM setting manually #1575
LauraMaier e9c9b31
Merge branch 'master' into issue1575_addPVModel
LauraMaier 0100780
Add comments and do refactoring #1575
LauraMaier aa801be
Adapt formatting #1575
LauraMaier 5d04aad
Reorganize PV model #1575
LauraMaier 7875491
Adapt units and cleanup #1575
LauraMaier d4fa081
Delete algorithm specification #1575
LauraMaier 9829b07
Adapt wrong Buildings paths #1575
LauraMaier 96d7d2f
Merge branch 'master' into issue1575_addPVModel
LauraMaier 84a332a
Replace with master file due to unintended changes #1575
LauraMaier 9281339
Replace with master version #1575
LauraMaier 3eec2db
HTML formatting and code formatting #1575
LauraMaier 7ae23d9
correct html #1575
LauraMaier ac01ba0
Minor changes #1575
LauraMaier 449a93d
Modify html code and delete Icon package #1575
LauraMaier e42bd96
Delete Icon Package #1575
LauraMaier 5cef094
Change from BOM #1575
LauraMaier 67f2ead
Formatted file
mwetter ac64815
Added citation
mwetter 9054f06
Added citation
mwetter b210eb0
Removed white spaces
mwetter 1443223
Revised documentation, fixed capitalization of image
mwetter 9f3c26b
Removed white spaces
mwetter 1df4070
Formatted file
mwetter 4b24bb7
Formatted text
mwetter 45d7e1e
Formatted text
mwetter 293a775
Corrected html
mwetter 5e68913
Formatted file
mwetter 06eff49
Formatted file
mwetter 4591ddb
Formatted file
mwetter 5c0078b
Formatted file
mwetter d2080e3
Formatted file
mwetter 21586ef
Formatted file
mwetter 3ef3df2
Formatted file
mwetter 8dff789
Replaced ModelicaServices
mwetter 93271a0
Rearranged icons and lines
mwetter 38ea31a
Formatted text
mwetter 79cd13a
Replaced ModelicaServices
mwetter 8a9e769
Formatted text
mwetter 737758d
Merge branch 'master' into issue1575_addPVModel
LauraMaier 4d1cb15
Add reference for Batzelis #1575
LauraMaier 3cb848e
Correct wrong explanation of air mass #1575
LauraMaier bc4e3fb
Remove contradicting phrase of exact and empirical #1575
LauraMaier a710f4e
Remov exponent of 1 to avoid regularization #1575
LauraMaier ac1d79a
added attributes for min and max
LauraMaier b8c98ee
Add regularization and adapt wording #1575
LauraMaier da24ec7
change wording in docu #1575
LauraMaier 437e257
Removed unnecessary default value #1575
LauraMaier 5342761
Deleted unnecessary default value #1575
LauraMaier 5e3ca5a
Improve readability in PartialPVSys #1575
LauraMaier 8de2575
Improve readability in Example PVSys #1575
LauraMaier c161d17
Add svg file for single-diode scheme #1575
LauraMaier a8c957b
Correct wrong declarations not matching the new variable names #1575
LauraMaier 6d05a72
delete no Event statements #1575
LauraMaier 0650445
Define minimum HGloTil #1575
LauraMaier 882385c
add regularization #1575
LauraMaier a37401f
Change number of rows in txt file #1575
LauraMaier f330c93
Reformulate model to distinguish from connect statements #1575
LauraMaier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Correct html code #1575
commit 1b2abcf1947289a680ab8e26dea73023ac6f8340
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The equations in this model need to be reformulated using regularization. Otherwise derivatives become discontinuous which can cause problems for solvers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mwetter I would appreciate some help and advice here, since I have never worked with regulation. Would it be possible to schedule a meeting next week?