Add prop to disable datatable filter cell popover useClickOutside #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
click outside hook in filter popovers
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
Also impacted by this as we are using webcomponents. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason:
The fix for #659 has broken filter popovers for applications that use the datatable inside the shadow DOM with webcomponents.
This is because the useClickOutside hook doesn't get the events propagated from the shadow DOM. This makes it so when we click any part of a control inside the popover, it will close the popover.
Suggested Fix:
I just added a prop that lets us disable this behavior. Some other ideas were to let the user pass in a custom Popover component for complete control.
What do you think?
@icflorescu