Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: int in-place testnet creation (backport #4297) #4338

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 3, 2024

close: #4244

This PR includes additional in-place-testnet command


This is an automatic backport of pull request #4297 done by Mergify.

(cherry picked from commit f7618d3)

# Conflicts:
#	docs/docs/03-CLI-Commands/01-cli-commands.md
#	ignite/pkg/chaincmd/chaincmd.go
Copy link
Contributor Author

mergify bot commented Sep 3, 2024

Cherry-pick of f7618d3 has failed:

On branch mergify/bp/release/v28.x.y/pr-4297
Your branch is up to date with 'origin/release/v28.x.y'.

You are currently cherry-picking commit f7618d3e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   changelog.md
	modified:   ignite/cmd/cmd.go
	new file:   ignite/cmd/testnet.go
	new file:   ignite/cmd/testnet_inplace.go
	new file:   ignite/pkg/chaincmd/in-place-testnet.go
	modified:   ignite/pkg/chaincmd/runner/chain.go
	modified:   ignite/services/chain/runtime.go
	new file:   ignite/services/chain/testnet.go
	modified:   ignite/templates/app/files/app/app.go.plush
	modified:   ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/commands.go.plush
	new file:   ignite/templates/app/files/cmd/{{binaryNamePrefix}}d/cmd/testnet.go.plush
	modified:   ignite/templates/app/files/go.mod.plush

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   docs/docs/03-CLI-Commands/01-cli-commands.md
	both modified:   ignite/pkg/chaincmd/chaincmd.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Sep 3, 2024
@github-actions github-actions bot added component:docs Documentation additions or improvements. component:ci CI/CD workflow and automated jobs. component:templates component:configs component:cmd type:services Service-related issues. component:packages labels Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Visit the preview URL for this PR (updated for commit fe3c15f):

https://igntservices-docs--pr4338-mergify-bp-release-v-2p0tooc2.web.app

(expires Tue, 10 Sep 2024 15:16:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 95379efd94dd497aaa37c2d0354e6e2cafca5ec5

@github-actions github-actions bot removed the component:docs Documentation additions or improvements. label Sep 3, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK!

Let's fix #4305 and #4318 ASAP and we are good for a minor release,

@julienrbrt julienrbrt enabled auto-merge (squash) September 4, 2024 19:30
@julienrbrt julienrbrt merged commit abbe7f3 into release/v28.x.y Sep 4, 2024
42 of 44 checks passed
@julienrbrt julienrbrt deleted the mergify/bp/release/v28.x.y/pr-4297 branch September 4, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants