Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Modin backends to dev requirements #366

Open
wants to merge 2 commits into
base: epic/modin
Choose a base branch
from
Open

Add Modin backends to dev requirements #366

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f74ee08
Add Modin backends to dev requirements
zmbc Jan 9, 2024
523bb03
Add Modin engines to test_requirements
zmbc Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@
"dev": doc_requirements
+ test_requirements
+ interactive_requirements
+ modin_requirements,
+ modin_requirements
+ ["ray", "dask"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be added to the modin_requirements list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modin has multiple backends (more even than these two) and they are all optional, since you can install any one of them and it will work. We don't want to force our users to install any particular backend, but for development I've been using these two (and I think we will test on these two, once we have automated tests for Modin).

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't have naked requirements declared here. Sounds like we need a separate variable to contain these requirements like modin_test_requirements. If we have automated tests for these, they should at least be within the "test" extra otherwise tests will fail if you only install .[test].

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmudambi I've updated this; let me know if it is better now. We don't actually have the automated tests yet, but we will want them before we merge the Modin epic.

"modin": modin_requirements,
},
# entry_points="""
Expand Down