Sbachmei/mic 5549/mypy results context #538
Conversation
stevebachmeier
requested review from
albrja,
collijk,
hussain-jafari,
patricktnast and
rmudambi
as code owners
| @@ -356,7 +356,7 @@ def _get_groups( | |||
| ) | |||
| else: | |||
| pop_groups = filtered_pop.groupby(lambda _: "all") | |||
| return pop_groups | |||
| return pop_groups # type: ignore[return-value] | |||
There was a problem hiding this comment.
Happy to talk about this. I think it's a discrepancy between mypy requiring DataFrameGroupBys to be generic and python RuntimeErroring w/ DataFrameGroupBy is not subscriptable. from __future__ import annotations does not fix like it does for pd.Series.
| @@ -301,7 +302,7 @@ def _bin_data(data: Union[pd.Series, pd.DataFrame]) -> pd.Series: | |||
|
|
|||
| def register_observation( | |||
| self, | |||
| observation_type, | |||
| observation_type: Type[BaseObservation], | |||
There was a problem hiding this comment.
This wasn't causing an error but it was just wrong. At this point we're sending in the class itself, NOT an instantiation of it (actually, it might be worth just saying observation_type: Type[StratifiedObservation | UnstratifiedObservation | AddingObservation | ConcatenatingObservation] if folks prefer b/c that's what it really is. But they all inherit from BaseObservation so this is less typing.
There was a problem hiding this comment.
Should BaseObservation be called Observation?
There was a problem hiding this comment.
I think we had it called that at once and changed it to this but now can't recall why. It does subclass from abc, though there are no abstract methods or anything on it. Probably doesn't matter?
There was a problem hiding this comment.
Type[C] is covariant, so I think putting in the base observation makes sense. It looks like there is a builtin type you could use instead, though
| @@ -301,7 +302,7 @@ def _bin_data(data: Union[pd.Series, pd.DataFrame]) -> pd.Series: | |||
|
|
|||
| def register_observation( | |||
| self, | |||
| observation_type, | |||
| observation_type: Type[BaseObservation], | |||
There was a problem hiding this comment.
Should BaseObservation be called Observation?
| @@ -60,7 +59,8 @@ class BaseObservation(ABC): | |||
| DataFrame or one with a complete set of stratifications as the index and | |||
| all values set to 0.0.""" | |||
| results_gatherer: Callable[ | |||
| [pd.DataFrame | DataFrameGroupBy[str], tuple[str, ...] | None], pd.DataFrame | |||
There was a problem hiding this comment.
I'm assuming the things in this file were just type-hinted incorrectly?
There was a problem hiding this comment.
Yeah, though I'm not gonna lie - I'm having trouble understanding how to type-hint DataFrameGroupBys...
Fix mypy errors in framework/results/context.py
Description
Changes and notes
Testing