Albrja/mic-5546/mypy framework time #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrja
requested review from
collijk,
hussain-jafari,
patricktnast,
rmudambi and
stevebachmeier
as code owners
|
There is not a CHANGELOG as of now because @patricktnast is exploring a way to deal with our generic time types. |
albrja
force-pushed
the
albrja/mypy-framework-time
branch
from
d286246
to
8acdaed
Compare
rmudambi
reviewed
Nov 13, 2024
src/vivarium/framework/time.py
Outdated
| self._standard_step_size: ClockStepSize = None | ||
| self._clock_step_size: ClockStepSize = None | ||
| self._individual_clocks: PopulationView = None | ||
| # return math.ceil((self.stop_time - self.time) / self.step_size) # type: ignore [operator] |
There was a problem hiding this comment.
Remove this commented line
hussain-jafari
approved these changes
Nov 13, 2024
stevebachmeier
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Albrja/mic-5546/mypy framework time
Fix mypy erros in framework/time.py
Changes and notes
Testing