Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transport improvements from 2025-W09 #300

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Feb 24, 2025

How to review

  • Read the diff and note that the CI checks all pass.
  • More TBA.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update doc/whatsnew.

@khaeru khaeru added enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model labels Feb 24, 2025
@khaeru khaeru self-assigned this Feb 24, 2025
@khaeru khaeru requested a review from glatterf42 as a code owner February 24, 2025 13:16
@khaeru khaeru marked this pull request as draft February 24, 2025 13:23
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 7.79221% with 71 lines in your changes missing coverage. Please review.

Project coverage is 56.3%. Comparing base (fcb0afe) to head (15d2a67).

Files with missing lines Patch % Lines
message_ix_models/model/transport/ldv.py 0.0% 36 Missing ⚠️
...sage_ix_models/tests/model/transport/test_build.py 0.0% 17 Missing ⚠️
message_ix_models/report/operator.py 17.6% 14 Missing ⚠️
message_ix_models/model/transport/operator.py 50.0% 2 Missing ⚠️
message_ix_models/model/transport/build.py 50.0% 1 Missing ⚠️
message_ix_models/model/transport/files.py 0.0% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (fcb0afe) and HEAD (15d2a67). Click for more details.

HEAD has 45 uploads less than BASE
Flag BASE (fcb0afe) HEAD (15d2a67)
48 3
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #300      +/-   ##
========================================
- Coverage   78.2%   56.3%   -22.0%     
========================================
  Files        217     217              
  Lines      16804   16828      +24     
========================================
- Hits       13154    9480    -3674     
- Misses      3650    7348    +3698     
Files with missing lines Coverage Δ
message_ix_models/util/common.py 100.0% <ø> (ø)
message_ix_models/model/transport/build.py 15.7% <50.0%> (-79.3%) ⬇️
message_ix_models/model/transport/files.py 0.0% <0.0%> (-98.7%) ⬇️
message_ix_models/model/transport/operator.py 18.4% <50.0%> (-67.9%) ⬇️
message_ix_models/report/operator.py 70.3% <17.6%> (-10.3%) ⬇️
...sage_ix_models/tests/model/transport/test_build.py 0.0% <0.0%> (-78.0%) ⬇️
message_ix_models/model/transport/ldv.py 0.0% <0.0%> (-96.8%) ⬇️

... and 69 files with indirect coverage changes

@khaeru khaeru force-pushed the transport/2025-w09 branch from ae09452 to 5daabc6 Compare February 26, 2025 15:52
- Move to .report.operator from .transport.operator.
- Add data/transport/input-share.csv, .transport.files.input_share.
- Incorporate via .ldv.prepare_tech_econ().
- Simplify key handling in prepare_tech_econ()
- Allow use of scenario="LED" in some cases and scenario="SSP1" in
  others.
- Select LDV load factor data using "LED" label where necessary.
@khaeru khaeru force-pushed the transport/2025-w09 branch from 93819ec to 15d2a67 Compare February 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enh New features or functionality transport MESSAGEix-Transport variant or transport in the base model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant