make unit a unused phantomdata in fmt::Arguments

the value of that type is never use, only the actual type parameter `N`
iliekturtles · Nov 3, 2023 · 5bb0d88 · 5bb0d88
1 parent 639c6b3
commit 5bb0d88
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/src/quantity.rs b/src/quantity.rs
@@ -343,10 +343,11 @@ macro_rules! quantity {
             where
                 N: Unit
             {
+                let _ = unit;
                 __system::fmt::Arguments {
-                    dimension: $crate::lib::marker::PhantomData,
-                    unit,
                     style,
+                    dimension: $crate::lib::marker::PhantomData,
+                    _unit: $crate::lib::marker::PhantomData,
                 }
             }
 
@@ -384,11 +385,12 @@ macro_rules! quantity {
             where
                 N: Unit
             {
+                let _ = unit;
                 __system::fmt::QuantityArguments {
                     arguments: __system::fmt::Arguments {
-                        dimension: $crate::lib::marker::PhantomData,
-                        unit,
                         style,
+                        dimension: $crate::lib::marker::PhantomData,
+                        _unit: $crate::lib::marker::PhantomData,
                     },
                     quantity: self,
                 }

diff --git a/src/system.rs b/src/system.rs
@@ -1423,11 +1423,11 @@ macro_rules! system {
             pub struct Arguments<D, N>
             where
                 D: Dimension + ?Sized,
-                N: Unit,
+                N: Unit + ?Sized,
             {
-                pub(super) dimension: $crate::lib::marker::PhantomData<D>,
-                pub(super) unit: N,
                 pub(super) style: DisplayStyle,
+                pub(super) dimension: $crate::lib::marker::PhantomData<D>,
+                pub(super) _unit: $crate::lib::marker::PhantomData<N>,
             }
 
             /// A struct to specify a display style and unit for a given quantity.