feat(web): shared link filters #15948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
feat/shared-link-filters
branch
from
f65291f to
154b7db
Compare
danieldietzler
approved these changes
Feb 7, 2025
Comment on lines
+49
to
+51
| await removeSharedLink({ id }); | ||
| notificationController.show({ message: $t('deleted_shared_link'), type: NotificationType.Info }); | ||
| await refresh(); |
There was a problem hiding this comment.
I think we could already optimistically remove the link from the array if the removeSharedLink call was successful, and then after that actually re-fetch the links. That could make it feel a bit more snappy
There was a problem hiding this comment.
True, I'll leave that for a follow-up though. There's definitely a lot of room for improvement though, this was how it was working previously.
| let filters = Object.keys(filterMap); | ||
| let labels = Object.values(filterMap); | ||
|
|
||
| const getActiveTab = (url: URL) => { |
There was a problem hiding this comment.
You only use that function in the $derived rune. Idk if that's cleaner, but an option would be to inline it instead with $derived.by(() => {}).
There was a problem hiding this comment.
I generally find this more readable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/shared-links/:idGroupTab