Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose.mdx #16069

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JasonMAnderson
Copy link

@JasonMAnderson JasonMAnderson commented Feb 13, 2025

This is an important step for Synology NAS users that have a firewall with a "Deny All" rule at the bottom. Since the containers are set-up in bridge mode for networking, the IP address of the Immich container needs to be forwarded along with port 2283.

Description

Fixes # (issue)

How Has This Been Tested?

  • Test A
  • Test B

Screenshots (if appropriate)

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable
  • I have no unrelated changes in the PR.
  • I have confirmed that any new dependencies are strictly necessary.
  • I have written tests for new code (if applicable)
  • I have followed naming conventions/patterns in the surrounding code
  • All code in src/services uses repositories implementations for database calls, filesystem operations, etc.
  • All code in src/repositories/ is pretty basic/simple and does not have any immich specific logic (that belongs in src/services)

This is an important step for Synology NAS users that have a firewall with a "Deny All" rule at the bottom.  Since the containers are set-up in bridge mode for networking, the IP address of the Immich container needs to be forwarded along with port 2283.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 13, 2025
Copy link
Contributor

@Mraedis Mraedis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JasonMAnderson you've broken up the "Docker Version" info box and also left the new section dangling (you need ::: at the end of a section). Best move your block below docker version or below health check interval.
Also, could you amend the title with the prefix docs: as is custom?

@JasonMAnderson
Copy link
Author

JasonMAnderson commented Feb 13, 2025

@Mraedis Sorry, I didn't have my docusaurus workflow working so couldn't preview. Any chance you can just include the text I suggested as appropriate in the docs as you see fit? We could then close this PR.

@alextran1502
Copy link
Contributor

I think this information should fit under synology deployment, similar to Unraid. However, we will need a synology setup guide and

@JasonMAnderson
Copy link
Author

@alextran1502 - Agreed, especially if you want to include instructions using Synology Container Manager for deployment vs. docker-compose. I'd be happy to write this if you guys want to go this route. Is there a contributor's guide to follow for new articles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:documentation documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants