feat(web): rotate image #16089
Open
feat(web): rotate image #16089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrasm91
force-pushed
the
feat/rotation
branch
from
832fb18 to
a3370d2
Compare
|
Wouldn't it be better to set the orientation tag in the preview and thumbnail instead of regenerating them? |
|
I can see if it is possible to update them by simply changing exif. I was under the impression that it wouldn't change how it displayed it. |
|
Deploying preview environment to https://pr-16089.preview.internal.immich.cloud/ |
jrasm91
force-pushed
the
feat/rotation
branch
from
a3370d2 to
4522959
Compare
|
@mertalev you combined all the jobs together, but thumbhash still needs to be regenerated when orientation changes. I can't be bothered to rewrite this just to prevent regenerating 2 thumbnails. |
jrasm91
force-pushed
the
feat/rotation
branch
from
4522959 to
779bff4
Compare
jrasm91
force-pushed
the
feat/rotation
branch
from
779bff4 to
9cd0871
Compare
mertalev
reviewed
Feb 14, 2025
| const orientation = useExtracted && asset.exifInfo?.orientation ? Number(asset.exifInfo.orientation) : undefined; | ||
| const orientation = asset.exifInfo?.orientation ? Number(asset.exifInfo.orientation) : undefined; |
There was a problem hiding this comment.
This is how it used to work and it was changed to handle HEIC files correctly.
web/src/lib/components/asset-viewer/actions/rotate-action.svelte
Outdated
Show resolved
Hide resolved
mertalev
requested changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image rotation
Description
This PR adds the rotation feature by saving/updating the
Orientationexif tag to a sidecar file. Afterwards, it queues jobs to regenerate thumbnails, which now use the saved orientation value. The only thing left to do is change the url so it can bypass the frontend cache which currently relies onasset.checksum, which isn't updated with this type of edit.API Changes
Fixes #8355 (and potentially double rotates other HEIF images, which can at least now be fixed in the web ui directly)