Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SDK)!: v2 SDK Release #2137

Merged
merged 111 commits into from
Feb 20, 2025
Merged

feat(SDK)!: v2 SDK Release #2137

merged 111 commits into from
Feb 20, 2025

Conversation

zaidarain1
Copy link
Contributor

@zaidarain1 zaidarain1 commented Sep 3, 2024

Changes

Major

  • Migrate to separate NPM packages and publish @imtbl/sdk and @imtbl/checkout-widgets, and their workspace dependencies recursively
  • Checkout widgets javascript is now loaded from the @imtbl/checkout-widgets package instead of needing to be copied to the @imtbl/sdk package
  • All packages now create both an esm and cjs javascript output file (Checkout remains the same)

Tooling

  • Migrate to Pnpm from yarn
  • Migrate to tsup from rollup (Checkout remains the same)
  • Upgrade NX to support pnpm v9
  • Migrate release process from release-it and custom scripts to nx release
  • Setup changelog generation to be handled via conventional commit-style PR titles

Misc

  • Make workspace versioning explicit
  • Cleanup cypress from Checkout
  • Add missing dependencies to package.jsons that were imported from previously (pnpm will not allow importing from dependencies that aren't listed in the package's package.json, unlike yarn)
  • Cleanup and remove many custom scripts not needed anymore

Copy link

nx-cloud bot commented Sep 3, 2024

View your CI Pipeline Execution ↗ for commit 53aad63.

Command Status Duration Result
nx run-many -p @imtbl/sdk,@imtbl/checkout-widge... ✅ Succeeded 6s View ↗
nx affected -t build,lint,test ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-20 03:24:00 UTC

@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 3 times, most recently from 5ed7a74 to 06119b8 Compare September 19, 2024 01:25
@shineli1984
Copy link
Collaborator

shineli1984 commented Sep 23, 2024

Please have a think about how do we indicate alpha packages in a release.

@zaidarain1 zaidarain1 self-assigned this Sep 23, 2024
@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 7 times, most recently from 86049cc to 6d3707d Compare September 27, 2024 06:09
@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 4 times, most recently from 960ca6e to 8246ecc Compare October 7, 2024 05:18
@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 2 times, most recently from c0b21c8 to 935c9d5 Compare November 27, 2024 05:59
@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 2 times, most recently from 37a6202 to 33bbb5b Compare December 5, 2024 05:07
@zaidarain1 zaidarain1 changed the title major poc V2 SDK Dec 13, 2024
@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 3 times, most recently from ba48734 to 517480e Compare January 31, 2025 02:16
@zaidarain1 zaidarain1 force-pushed the feat/major-poc branch 3 times, most recently from 7d9508d to 6d1656a Compare February 19, 2025 02:02
@zaidarain1 zaidarain1 marked this pull request as ready for review February 20, 2025 00:27
@zaidarain1 zaidarain1 requested review from a team as code owners February 20, 2025 00:27
lfportal
lfportal previously approved these changes Feb 20, 2025
shineli1984
shineli1984 previously approved these changes Feb 20, 2025
nattb8
nattb8 previously approved these changes Feb 20, 2025
aerim-yi
aerim-yi previously approved these changes Feb 20, 2025
w3njah
w3njah previously approved these changes Feb 20, 2025
Copy link

@w3njah w3njah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for files under .github/* after addressing the comments.
Lets use commit hashes instead of tags for all action imports. If you could address it for all cases accros all actions it would be great!

@zaidarain1 zaidarain1 added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit dd9750a Feb 20, 2025
7 checks passed
@zaidarain1 zaidarain1 deleted the feat/major-poc branch February 20, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants