feat: Add search to from and to fields in swap form #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithbro-imx
previously approved these changes
Feb 20, 2025
Comment on lines
34
to
43
| const filterOptions = useCallback((filterBy: string) => { | ||
| const filterByLower = filterBy.toLowerCase(); | ||
| return options.filter((option) => option.name.toLowerCase().includes(filterByLower) | ||
| || option.symbol.toLowerCase().includes(filterByLower) | ||
| || option.id.toLowerCase().endsWith(filterByLower)); | ||
| }, [options]); | ||
|
|
||
| const filteredOptions = !searchValue | ||
| ? options | ||
| : filterOptions(searchValue); |
There was a problem hiding this comment.
Should this just be one thing in a useMemo? Otherwise it filter on every render
|
View your CI Pipeline Execution ↗ for commit 1e36d2c.
☁️ Nx Cloud last updated this comment at |
keithbro-imx
approved these changes
Feb 20, 2025
| return options; | ||
| } | ||
| return filterOptions(searchValue, options); | ||
| }, [options, searchValue, filterOptions]); |
There was a problem hiding this comment.
filterOptions doesn't need to be a dep now
There was a problem hiding this comment.
I wasn't sure if linter would complain or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please prefix this PR's title with:
breaking-change:if you have introduced modification that necessitates immediate adjustments by this SDK's users to their applications, clients, or integrations to avert disruptions to existing features or functionalities.feat:,fix:,refactor:,docs:, orchore:.Summary
Allows filtering tokens in from and to list in the swap form - can search by name, symbol or contract address
Screen.sharing.-.2025-02-20.1_43_13.PM.mp4