Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: provide support for packages when dependencies do not exist (package-lock v3) #104

Merged
merged 5 commits into from
Apr 29, 2024

Conversation

ryndh
Copy link
Contributor

@ryndh ryndh commented Apr 26, 2024

Doing some testing on failures happening with converting package-lock.json files with "lockfileVersion": 3, and tested out the solution mentioned in this issue: #99

Using this fork, I was able to get a successful conversion, where previous attempts with package-lock.json v3 had failed.

@antongolub
Copy link
Collaborator

antongolub commented Apr 27, 2024

Hey, @ryndh,

Thanks for the fix. But are you sure, that ?? syntax is supported in nodejs v12?

@ryndh
Copy link
Contributor Author

ryndh commented Apr 29, 2024

But are you sure, that ?? syntax is supported in nodejs v12?

Ah, good call – switched it to ||

@antongolub
Copy link
Collaborator

Now everything seems fine, thanks.
Could you also revert changelog.md? We use semrel to update the data automatically.

@antongolub antongolub merged commit 5696017 into imsnif:master Apr 29, 2024
11 checks passed
Copy link
Collaborator

@antongolub antongolub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antongolub
Copy link
Collaborator

Finally released: 1.9.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants