fix: typehinting react useForm with interface #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasweiss
commented
Feb 24, 2025
| @@ -6,7 +6,7 @@ import useRemember from './useRemember' | |||
| type setDataByObject<TForm> = (data: TForm) => void | |||
| type setDataByMethod<TForm> = (data: (previousData: TForm) => TForm) => void | |||
| type setDataByKeyValuePair<TForm> = <K extends keyof TForm>(key: K, value: TForm[K]) => void | |||
| type FormDataType = Record<string, FormDataConvertible> | |||
| type FormDataType = Partial<Record<string, FormDataConvertible>> | |||
There was a problem hiding this comment.
If you prefer, I think we could also go for this notation, I don't mind either one.
Suggested change
| type FormDataType = Partial<Record<string, FormDataConvertible>> | |
| type FormDataType = { [key:string]?: FormDataConvertible } |
matthiasweiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Really love all of the great work you are doing with Inertia, by far my favorite way to build web apps 🥳
A previous PR (#2060) introduced stricter typing for the useForm hook.
However, this unfortunately breaks typehinting the hook, since the hook now requires and index signature for the generic. This also causes in the new Laravel starter kit, see laravel/react-starter-kit#31 for more info.
This PR fixes this, and also closes #2188.