Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logs to monitor #149

Merged
merged 3 commits into from
Feb 19, 2025
Merged

feat: add logs to monitor #149

merged 3 commits into from
Feb 19, 2025

Conversation

yaojp123
Copy link
Contributor

@yaojp123 yaojp123 commented Feb 19, 2025

What does this PR do

This pull request includes significant changes to the monitoring components and localization files, as well as the addition of new log components. The most important changes include updates to the Monitor component, localization enhancements, and the addition of log components for cluster and node monitoring.

Updates to Monitor component:

Localization enhancements:

  • Added new localization strings for log components and tabs in English. (web/src/locales/en-US/cluster.js, [1] [2]
  • Added new localization strings for log components and tabs in Chinese. (web/src/locales/zh-CN/cluster.js, web/src/locales/zh-CN/cluster.jsR118-R132)

Addition of log components:

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luohoufu luohoufu merged commit 8452d8e into main Feb 19, 2025
6 checks passed
@luohoufu luohoufu deleted the feat-logs branch February 19, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants