Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preserve audit log default sorting across pagination #161

Merged
merged 2 commits into from
Feb 21, 2025
Merged

fix: preserve audit log default sorting across pagination #161

merged 2 commits into from
Feb 21, 2025

Conversation

silenceqi
Copy link
Contributor

@silenceqi silenceqi commented Feb 21, 2025 •
edited
Loading

What does this PR do

preserve audit log default sorting across pagination, fixed issue #85

Rationale for this change

Standards checklist

  • The PR title is descriptive
  • The commit messages are semantic
  • Necessary tests are added
  • Updated the release notes
  • Necessary documents have been added if this is a new feature
  • Performance tests checked, no obvious performance degradation

@silenceqi silenceqi mentioned this pull request Feb 21, 2025
Closed
luohoufu
luohoufu approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@luohoufu luohoufu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luohoufu luohoufu merged commit aa67bf7 into main Feb 21, 2025
6 checks passed
@luohoufu luohoufu deleted the fix-audit-log branch February 21, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luohoufu luohoufu luohoufu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@silenceqi @luohoufu