fix: create file before put content to it #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silenceqi
approved these changes
Jan 23, 2025
medcl
reviewed
Feb 13, 2025
modules/configs/config/config.go
Outdated
| @@ -138,6 +137,11 @@ func SaveConfigStr(name, content string) error { | |||
| } | |||
| } | |||
|
|
|||
| _, err = util.CreateFile(cfgDir, "") | |||
There was a problem hiding this comment.
create a file with cfDir?
better to use os.mkdirall instead i guess
There was a problem hiding this comment.
let me change it.
medcl
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
This pull request includes changes to the
SaveConfigStrfunction in themodules/configs/config/config.gofile to improve error handling and ensure the configuration directory exists before saving the configuration file.Improvements to error handling and directory creation:
modules/configs/config/config.go, modules/configs/config/config.goR140-R144)modules/configs/config/config.go, modules/configs/config/config.goL122)Rationale for this change
Standards checklist