test: pr check code lint and unit test #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveLauC
reviewed
Jan 10, 2025
| - name: Checkout current repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
Per the documentation of this action:
Only a single commit is fetched by default, for the ref/SHA that triggered the workflow. Set
fetch-depth: 0to fetch all history for all branches and tags.
Do we need to fetch all the things?
There was a problem hiding this comment.
It is currently useless. If we add conditions to test other branches, we need to use them at this time.
SteveLauC
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
pr check code lint and unit test
Rationale for this change
This pull request introduces a new GitHub Actions workflow for PR checks and removes the existing unit test workflow. It also includes minor code formatting changes and updates to improve readability and consistency.
GitHub Actions Workflows:
.github/workflows/pr-check.yml: Added a new workflow namedPR-Checkwhich includes jobs for unit testing and code linting. This workflow is triggered on pull requests to themainbranch..github/workflows/unit_test.yml: Removed the existing unit test workflow.Code Formatting and Updates:
main.go: Reordered imports to group external packages together for better readability.main.go: Updated the usage ofutil.ByteValueto use named fields for clarity in multiple print statements. [1] [2] [3]Standards checklist