Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set stop time based off query bounds if query is grouped by time #1773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petetnt
Copy link
Contributor

@petetnt petetnt commented Jan 23, 2018

Required for all non-trivial PRs
  • Rebased/mergable
  • [?] Tests pass (couldn't run the tests locally for some reason)
  • CHANGELOG.md updated (Should I do this)
  • Sign CLA (if not already signed)

Fixes #1765. When the batches were grouped by time, the time on the BatchPoint was only being updated every hour (?).

Not quite sure if this is the correct part of the code to fix though as I don't completely grasp the complexities of either Go not Kapacitor. However it does now produce correct output every time the groupBy is being called (that is whatever is set to the every on the TICKScript)

@nathanielc can you confirm?

@petetnt
Copy link
Contributor Author

petetnt commented Jan 23, 2018

Tests seem to flake due to a precision issue?

--- FAIL: TestServer_BatchTask (0.69s)
	server_test.go:3027: unexpected result
		got {"series":[{"name":"cpu","columns":["time","count"],"values":[["2018-01-23T11:00:55.999Z",2]]}]}
		exp {"series":[{"name":"cpu","columns":["time","count"],"values":[["2018-01-23T11:00:56Z",2]]}]}
=== RUN   TestServer_BatchTask_InfluxDBConfigUpdate
--- FAIL: TestServer_BatchTask_InfluxDBConfigUpdate (0.69s)
	server_test.go:3174: unexpected result
		got {"series":[{"name":"cpu","columns":["time","count"],"values":[["2018-01-23T11:00:56.689Z",2]]}]}
		exp {"series":[{"name":"cpu","columns":["time","count"],"values":[["2018-01-23T11:00:56.69Z",2]]}]}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

groupBy not grouping by a tag created with eval
1 participant