Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alerta node hang by adding http timeout and fix time.Duration convert when define topic handler with httppost #2062

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Ehekatl
Copy link

@Ehekatl Ehekatl commented Sep 20, 2018

After run into kapacitor tasks hang several time, I found it's caused by lack of http timeout support in alerta service.

this pr also fixed one of many issues where you can't use timeout in string within topic handler options.
I only did it for http post though.

e.g.

---
id: test
topic: test
kind: post
match: level() == CRITICAL
options:
  endpoint: 'media-as2s'
  timeout: 10s
Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant