-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(inputs.proxmox): Add tag VM_ID to Proxmox plugin #16066
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all thank you very much for your contribution @superdiego98! Much appreciated!
However, we cannot add the tag unconditionally as this would create new "series" in some of the output plugins and thus might cause problems for some users! Could you please add a setting to the config where the user can specify which parts of vmstat
they want to add as tags e.g.
## Additional tags of the VM stats data to add as a tag for example
## additional_vmstats_tags = ["vmid", "status"]
# additional_vmstats_tags = []
What do you think?
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Hi, |
@superdiego98 let me know if you need help! |
Summary
Checklist
Related issues
resolves #16065