Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.proxmox): Add tag VM_ID to Proxmox plugin #16066

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

superdiego98
Copy link

@superdiego98 superdiego98 commented Oct 22, 2024

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16065

@superdiego98 superdiego98 changed the title Add tag VM_ID to Proxmox plugin feat(inputs.proxmox): Add tag VM_ID to Proxmox plugin Oct 22, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 22, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all thank you very much for your contribution @superdiego98! Much appreciated!

However, we cannot add the tag unconditionally as this would create new "series" in some of the output plugins and thus might cause problems for some users! Could you please add a setting to the config where the user can specify which parts of vmstat they want to add as tags e.g.

  ## Additional tags of the VM stats data to add as a tag for example
  ## additional_vmstats_tags = ["vmid", "status"]
  # additional_vmstats_tags = []

What do you think?

@srebhan srebhan self-assigned this Oct 24, 2024
@srebhan srebhan added the waiting for response waiting for response from contributor label Oct 29, 2024
@superdiego98
Copy link
Author

superdiego98 commented Oct 29, 2024

Hi,
i think this could be a great solution I can try to implement . Programming isn't my daily routine so i'm not sure if i could succeed but i'll try it!

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Oct 29, 2024
@srebhan
Copy link
Member

srebhan commented Oct 30, 2024

@superdiego98 let me know if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.proxmox] Add VM ID to proxmox input plugin tags
2 participants