Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: sentry sourcemap upload once #1764

Merged
merged 3 commits into from
Mar 5, 2025

Conversation

mkazlauskas
Copy link
Member

@mkazlauskas mkazlauskas commented Mar 5, 2025

Checklist

  • JIRA - <LW-12393>
  • Proper tests implemented
  • Screenshots added.

Proposed solution

See Jira ticket

@mkazlauskas mkazlauskas requested a review from rhyslbw March 5, 2025 14:19
@mkazlauskas mkazlauskas requested review from a team as code owners March 5, 2025 14:19
previously it was uploaded twice for every release:
- for SW build
- for UI build
sometimes we need to associate sentry errors with Lace version
having version in release name will make it easier
@mkazlauskas mkazlauskas force-pushed the chore/sentry-sourcemap-upload-once branch from 7102def to 651ec30 Compare March 5, 2025 14:22
Copy link

sonarqubecloud bot commented Mar 5, 2025

Copy link
Member

@rhyslbw rhyslbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, great job on the custom version too ❤️

@mchappell
Copy link
Collaborator

Great work! if we need to take the version any futher we could add the github job run/branch/other detail to it in future

@mkazlauskas mkazlauskas merged commit be0281a into main Mar 5, 2025
30 of 31 checks passed
@mkazlauskas mkazlauskas deleted the chore/sentry-sourcemap-upload-once branch March 5, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants