[minor] Fixing some warnings #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanmelle
approved these changes
May 17, 2019
| @@ -243,7 +243,7 @@ private extension NTPConnection { | |||
| return | |||
| } | |||
|
|
|||
| let packet = data.withUnsafeBytes { $0.pointee as ntp_packet_t }.nativeEndian | |||
| let packet = data.withUnsafeBytes { $0.load(as: ntp_packet_t.self) }.nativeEndian | |||
There was a problem hiding this comment.
have never used load(as: ... so ... sure!
|
@dhavalshreyas @rvanmelle |
|
@00FA9A |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you change and why?
Fixing some Xcode warnings.
Potential risks introduced?
None
What tests were performed (include steps)?
Compile and tests.
Checklist