Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction id support to makara_abstract_adapter #273

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add transaction id support to makara_abstract_adapter #273

wants to merge 3 commits into from

Conversation

elguapo1611
Copy link

@elguapo1611 elguapo1611 commented Nov 2, 2020 •
edited
Loading

Always run select txid_current() on master without sticking.

thomasfulton
thomasfulton previously approved these changes Nov 2, 2020
View reviewed changes
@elguapo1611 elguapo1611 marked this pull request as ready for review November 2, 2020 21:48
@levkk
Copy link

levkk commented Nov 3, 2020

You sure this function can be called on a replica to find out what it's current transaction ID is? I was thinking we'd use pg_current_wal_lsn()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasfulton thomasfulton thomasfulton left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elguapo1611 @levkk @thomasfulton