Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced the ability to listen for the correct completion of each request. #116

Closed

Conversation

LosDanieloss
Copy link

I've encountered similar issue to the one described in issue #109 . Thought that will be cool to be able to observe successful response per request not as whole initialization. It's because as explained in mentioned issue init will fail if even single request fail but actually now() will return time even if only one request succeeded. So here is my proposed solution. It'll allow to know if at least one request during synchronization succeeded or will allow the user of the library want he/she could implement some sort of threshold of successful requests like author of issue #109 suggested.

@kaushikgopal
Copy link
Collaborator

@LosDanieloss 🙏 thank you so much for these changes. TrueTime has since undergone massive changes with the migration to Kotlin + Coroutines.

I did take your suggestion however and added a parameter now called strictNtpMode which effectively does what you're suggesting. Feel free to reopen if you have more suggestions/comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants