Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Attribution step status and filling input box on context selection from a file #620

Merged
merged 2 commits into from
Feb 25, 2025
Merged

Fixes for Attribution step status and filling input box on context selection from a file #620

merged 2 commits into from
Feb 25, 2025

Conversation

jeff-phillips-18
Copy link
Collaborator

Description

  • Adds a fix to set the status for the Attribution step in the knowledge wizard
  • Adds a fix to properly fill the context input area when selecting context from a file

@jeff-phillips-18 jeff-phillips-18 force-pushed the fixes branch 2 times, most recently from b5fb8c8 to 1c28238 Compare February 25, 2025 20:51
@vishnoianil
Copy link
Member

@jeff-phillips-18 DCO job is still failing, you need to signoff both the commit to make it happy.

vishnoianil
vishnoianil approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@vishnoianil vishnoianil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishnoianil vishnoianil merged commit e2ac614 into instructlab:main Feb 25, 2025
5 checks passed
@jeff-phillips-18 jeff-phillips-18 deleted the fixes branch February 25, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnoianil vishnoianil vishnoianil approved these changes

@nerdalert nerdalert Awaiting requested review from nerdalert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeff-phillips-18 @vishnoianil