[SYCL] Remove TODO/fix typos in address_cast.hpp
#15435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extension is aligned with core SYCL wording for `address_space_cast`, both do not expect decorated C++ pointers as operands. Long-term plans are to replace `multi_ptr` with `annotated_ptr`, so carefully crafting the wording in both SYCL core and the extension isn't a priority right now.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| @@ -60,9 +56,8 @@ multi_ptr<ElementType, Space, access::decorated::no> | |||
| dynamic_address_cast(ElementType *Ptr) { | |||
| using ret_ty = multi_ptr<ElementType, Space, access::decorated::no>; | |||
| #ifdef __SYCL_DEVICE_ONLY__ | |||
| // TODO: Remove this restriction. | |||
There was a problem hiding this comment.
This comment is removed, but I don't really see any restriction being removed. Can you explain?
There was a problem hiding this comment.
See comments starting with #15423 (comment), plus the description of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The extension is aligned with core SYCL wording for
address_space_cast, both do not expect decorated C++ pointers as operands. Long-term plans are to replacemulti_ptrwithannotated_ptr, so carefully crafting the wording in both SYCL core and the extension isn't a priority right now.