[SYCL] Fix vec constructors #17712

aelovikov-intel · 2025-03-28T16:02:53Z

Note that the "test" changes here are less of the documentation of "intent" but rather the documentation of the effect of the change.

Also, the idea behind specification changes was to keep all "reasonable" code in the wild compiling and several changes are needed together to make that happen. Until all of them land, keep the new code out of -fpreview-breaking-changes mode.

aelovikov-intel · 2025-03-28T16:03:47Z

sycl/include/sycl/detail/type_traits/vec_marray_traits.hpp

+// `__SYCL_USE_PREVIEW_VEC_IMPL` at that time as well.
+#define __SYCL_USE_PREVIEW_VEC_IMPL 0
+#else
+#define __SYCL_USE_PREVIEW_VEC_IMPL 0


@AlexeySachkov , any better suggestions for the naming here?

One issue is that we want to preserve current/"old" version after next major release, when the meaning of "preview" would change. On the other hand, we can rename the macro at that time, maybe.

One issue is that we want to preserve current/"old" version after next major release, when the meaning of "preview" would change. On the other hand, we can rename the macro at that time, maybe.

If we plan to expose the macro to users so that they could do a switch back (for whichever reason), then it is better not to rename it later, but agree on a name from the beginning - otherwise renaming would be an API change by itself.

What about something like __SYCL_USE_SYCL2020_CONFORMANT_IMPL? I.e. indicate the intent instead of old/new where the meaning of old/new changes in time.

SYCL2020 has had several different specifications for vec. I've come up with __SYCL_USE_LEGACY_VEC_IMPL (meaning the current default). Alternatively, we can use the current major version (__SYCL_USE_SYCL8_VEC_IMPL).

@AlexeySachkov , can you take another look?

KhronosGroup/SYCL-Docs#670 Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of intel#17712 and intel#17713. With these three pieces in place we can keep building CTS successfully, so enable this new implementation (via `__SYCL_USE_PREVIEW_VEC_IMPL`) automatically under `-fpreview-breaking-changes` mode.

These will be updated as I upload PRs to implement recent specification changes.

Implements KhronosGroup/SYCL-Docs#668. Note that the "test" added here is less of a documentation of "intent" but rather the documentation of the effect of the change. Also, the idea behind specification changes was to keep all "reasonable" code in the wild compiling and several changes are needed together to make that happen. Until all of them land, keep the new code out of `-fpreview-breaking-changes` mode.

KhronosGroup/SYCL-Docs#670 Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of intel#17712 and intel#17713. With these three pieces in place we can keep building CTS successfully, so enable this new implementation (via `__SYCL_USE_PREVIEW_VEC_IMPL`) automatically under `-fpreview-breaking-changes` mode.

sycl/test/basic_tests/vectors/assign.cpp

uditagarwal97 · 2025-03-31T02:44:15Z

sycl/test/basic_tests/vectors/assign.cpp

+using sw_double_2 = decltype(std::declval<vec<double, 4>>().swizzle<1, 2>());
+
+#if __INTEL_PREVIEW_BREAKING_CHANGES
+#define NOT_IN_PREVIEW !


NIT; how about we rename this macro to something like NEGATE_IF_NOT_IN_PREVIEW ?

I don't see how it would help, honestly. This isn't "! in preview", but rather simply English, like "hey this holds, except not in preview".

This isn't "! in preview", but rather simply English, like "hey this holds, except not in preview".

Initially, I had the same confusion. That's why I'd have renamed this macro to NEGATE_IF_NOT_IN_PREVIEW or something. Anyway, I don't have strong opinion on this.

KhronosGroup/SYCL-Docs#670 Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of intel#17712 and intel#17713. With these three pieces in place we can keep building CTS successfully, so enable this new implementation (via `__SYCL_USE_PREVIEW_VEC_IMPL`) automatically under `-fpreview-breaking-changes` mode.

aelovikov-intel · 2025-04-01T20:00:05Z

Dev-IGC infrastructural failures are unrelated and can be seen in other PRs (e.g., https://github.com/intel/llvm/actions/runs/14201400451)

KhronosGroup/SYCL-Docs#670 Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of intel#17712 and intel#17713.

Implements KhronosGroup/SYCL-Docs#670. Technically, we also implement part of KhronosGroup/SYCL-Docs#674 (`std::byte` as element type) here, but there is no reasonable way to make them completely independent. This is built on top of #17712 and #17713.

aelovikov-intel requested a review from a team as a code owner March 28, 2025 16:02

aelovikov-intel requested review from againull and uditagarwal97 March 28, 2025 16:02

aelovikov-intel had a problem deploying to WindowsCILock March 28, 2025 16:03 — with GitHub Actions Error

aelovikov-intel requested a review from AlexeySachkov March 28, 2025 16:03

aelovikov-intel commented Mar 28, 2025

View reviewed changes

aelovikov-intel force-pushed the fix-vec-ctors branch from 28e9326 to 48897d1 Compare March 28, 2025 16:31

aelovikov-intel had a problem deploying to WindowsCILock March 28, 2025 16:31 — with GitHub Actions Error

aelovikov-intel force-pushed the fix-vec-ctors branch from 48897d1 to f92eb90 Compare March 28, 2025 16:49

aelovikov-intel temporarily deployed to WindowsCILock March 28, 2025 16:49 — with GitHub Actions Inactive

aelovikov-intel mentioned this pull request Mar 28, 2025

[SYCL] Add vec explicit conversion #17713

Merged

aelovikov-intel temporarily deployed to WindowsCILock March 28, 2025 17:50 — with GitHub Actions Inactive

aelovikov-intel had a problem deploying to WindowsCILock March 28, 2025 17:50 — with GitHub Actions Error

aelovikov-intel added 2 commits March 28, 2025 13:15

[NFC][SYCL] Add few vec tests to document current behavior

80c6fe3

These will be updated as I upload PRs to implement recent specification changes.

aelovikov-intel force-pushed the fix-vec-ctors branch from f92eb90 to a0979df Compare March 28, 2025 20:50

aelovikov-intel temporarily deployed to WindowsCILock March 28, 2025 20:50 — with GitHub Actions Inactive

aelovikov-intel mentioned this pull request Mar 28, 2025

[SYCL] Fix 1-element vec ambiguities #17722

Merged

aelovikov-intel temporarily deployed to WindowsCILock March 28, 2025 21:22 — with GitHub Actions Inactive

uditagarwal97 reviewed Mar 31, 2025

View reviewed changes

sycl/test/basic_tests/vectors/assign.cpp Outdated Show resolved Hide resolved

uditagarwal97 reviewed Mar 31, 2025

View reviewed changes

aelovikov-intel added 2 commits March 31, 2025 10:12

Merge remote-tracking branch 'origin/sycl' into HEAD

0d7c6dd

Let's settle on "future" macros here

cb22962

aelovikov-intel mentioned this pull request Mar 31, 2025

[NFC][SYCL] Add few vec tests to document current behavior #17720

Merged

aelovikov-intel added 2 commits March 31, 2025 11:04

Merge branch 'vec-tests' into fix-vec-ctors

a6bb094

Rename __SYCL_USE_PREVIEW_VEC_IMPL->__SYCL_USE_LIBSYCL8_VEC_IMPL

d16dd21

aelovikov-intel temporarily deployed to WindowsCILock March 31, 2025 18:13 — with GitHub Actions Inactive

aelovikov-intel temporarily deployed to WindowsCILock March 31, 2025 19:05 — with GitHub Actions Inactive

aelovikov-intel added 2 commits April 1, 2025 09:25

Merge remote-tracking branch 'origin/sycl' into HEAD

ed681fb

Update comment

79e0e15

aelovikov-intel requested a review from uditagarwal97 April 1, 2025 16:26

aelovikov-intel temporarily deployed to WindowsCILock April 1, 2025 16:26 — with GitHub Actions Inactive

uditagarwal97 approved these changes Apr 1, 2025

View reviewed changes

aelovikov-intel temporarily deployed to WindowsCILock April 1, 2025 17:10 — with GitHub Actions Inactive

aelovikov-intel merged commit aa0068b into intel:sycl Apr 1, 2025
21 of 23 checks passed

aelovikov-intel deleted the fix-vec-ctors branch April 1, 2025 20:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SYCL] Fix vec constructors #17712

[SYCL] Fix vec constructors #17712

aelovikov-intel commented Mar 28, 2025 •

edited

Loading

aelovikov-intel Mar 28, 2025

aelovikov-intel Mar 28, 2025

AlexeySachkov Mar 31, 2025

aelovikov-intel Mar 31, 2025

aelovikov-intel Apr 1, 2025

uditagarwal97 Mar 31, 2025

aelovikov-intel Mar 31, 2025

uditagarwal97 Mar 31, 2025

aelovikov-intel commented Apr 1, 2025

[SYCL] Fix vec constructors #17712

[SYCL] Fix vec constructors #17712

Conversation

aelovikov-intel commented Mar 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aelovikov-intel commented Apr 1, 2025

aelovikov-intel commented Mar 28, 2025 •

edited

Loading