Fix/clean-up the build for lmbench #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the heads-up that meta-oe of Yocto is planning on integrating a couple
of changes to lmbench.
These changes can be wrapped up around fixing/cleaning up as follows:
- if lmbench doesn't use a return from a function attributed to warn_unused_result
supress the warning/s
- fix buffer overflow
- define feature_test_macro _GNU_SOURCE compiling in sched_{get,set}affinity()
- go strict for a pre-build check if sched_{get,set}affinity() from glibc builds
cleanly. If it is not compile it out.
Please find the original discussion on the changes at meta-oe
http://lists.openembedded.org/pipermail/openembedded-devel/2019-October/202206.html
I have tested these changes against this repo and they build just fine.
The compiler warns though about the changes which already are in the meta-oe and
are not part of this commit.
Signed-off-by: Marek Bykowski <[email protected]>
Reviewed-off-by: Marcin Lapaj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the heads-up that meta-oe of Yocto is planning on integrating a couple
of changes to lmbench.
These changes can be wrapped up around fixing/cleaning up as follows:
supress the warning/s
cleanly. If it is not compile it out.
Please find the original discussion on the changes at meta-oe
http://lists.openembedded.org/pipermail/openembedded-devel/2019-October/202206.html
I have tested these changes against this repo and they build just fine.
The compiler warns though about the changes which already are in the meta-oe and
are not part of this commit.
Signed-off-by: Marek Bykowski [email protected]
Reviewed-off-by: Marcin Lapaj [email protected]