fix: update popup data along with icon #611
Draft
+124
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: content
Extension builds preview
|
){kind=icon}
){kind=icon}
sidvishnoi
force-pushed
the
popup-tab-data
branch
from
1e282c1
to
8c6287b
Compare
github-actions
bot
removed
the
area: content
sidvishnoi
force-pushed
the
popup-tab-data
branch
2 times, most recently
from
217fe8c
to
68fa7fb
Compare
- refactor(PopupState): add all popup data related to tab under `tab` key
- `tabUrl` -> `tab.url`
- `isSiteMonetized` -> `tab.isMonetized`
- `hasAllSessionsInvalid`
-> `tab.cannotMonetizeReason === 'all_sessions_invalid'`
- refactor(monetization): extract `getPopupTabData` to tabState service
- refactor(tabEvents): use `getPopupTabData` instead of multiple params
Paves way to show more useful messages with `tab.cannotMonetizeReason`
(e.g. new tab, internal extension pages, non-https pages)
sidvishnoi
force-pushed
the
popup-tab-data
branch
from
68fa7fb
to
baa45f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Rebase after #608
Changes proposed in this pull request
tabUrl->tab.urlisSiteMonetized->tab.isMonetizedhasAllSessionsInvalid->tab.cannotMonetizeReason === 'all_sessions_invalid'getPopupTabDatato tabState servicegetPopupTabDatainstead of multiple paramsPaves way for showing more useful messages with
tab.cannotMonetizeReason(e.g. new tab, internal extension pages, non-https pages) (#584)